adamsaghy commented on code in PR #5164: URL: https://github.com/apache/fineract/pull/5164#discussion_r2556322116
########## fineract-client-feign/src/main/java/org/apache/fineract/client/feign/support/FeignResponseHeaderHolder.java: ########## @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.client.feign.support; + +import feign.Response; +import java.util.Collection; +import java.util.Collections; +import java.util.Map; + +/** + * Thread-local holder for the last Feign response headers. This is primarily used by E2E tests that need to assert on + * HTTP headers when using Feign clients that otherwise only expose the deserialized body. + */ +public final class FeignResponseHeaderHolder { Review Comment: I’m concerned that using a ThreadLocal store may not be the right approach here. Since the header checks happen after the client call, the header values may already be removed or modified by that point. It would be safer to use the endpoints that return ApiResponse via the withHttpInformation methods, so we can retrieve both the response data and the headers directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
