sidshas03 commented on PR #5038: URL: https://github.com/apache/fineract/pull/5038#issuecomment-3603704869
hey @adamsaghy Thank you for the review and sorry for the delay in making changes. As per your feedback, I have done the following: - Removed the duplicate messages - The validation messages for Interest Rate Chart were present in both fineract-command and fineract-provider modules. I have removed them from fineract-command/src/test/resources/ and kept them only in fineract-provider/src/main/resources/ which is the proper production location. - Rebased and squashed commits - All 6 commits have been squashed into a single commit and rebased with latest develop branch. - Kindly review and let me know if any other changes are required. Thanks & Regards -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
