Aman-Mittal commented on code in PR #5223:
URL: https://github.com/apache/fineract/pull/5223#discussion_r2620083971
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -3188,6 +3188,30 @@ private void updateInstallmentsByModelForReAging(final
LoanTransaction loanTrans
loanChargeRepaymentScheduleProcessing.reprocess(ctx.getCurrency(),
loanTransaction.getLoan().getDisbursementDate(),
installments, loanCharge);
}
+
Review Comment:
This logic is implemented within
private void updateInstallmentsByModelForReAging
Which is already have too many responsibilities. Extracting this logic to
separate function is recommended.
And in log run it will be noted in future use if this function's cognitive
complexity can reduced.
so that it can be unit test more in isolation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
