lugosidomotor opened a new pull request, #5238:
URL: https://github.com/apache/fineract/pull/5238

   ## Description
   
   This PR improves the Kubernetes deployment configuration for better 
compatibility with Minikube and local development environments.
   
   ### Changes made:
   
   **Kubernetes deployment improvements:**
   - Added nginx reverse proxy configuration to `mifos-community` deployment to 
forward `/fineract-provider` API requests to the fineract-server backend, 
eliminating the need for separate ingress configuration
   - Switched from `openmf/community-app` to `openmf/web-app:master` image for 
better configurability via ConfigMap
   - Added `environment.json` ConfigMap for configuring the web-app frontend 
API URLs
   - Fixed liveness/readiness probe settings:
     - Reduced `initialDelaySeconds` (180s → 90s/60s for fineract-server, 90s → 
10s/5s for mifos-community)
     - Increased `periodSeconds` (1s → 10s) to reduce unnecessary load
     - Added `failureThreshold: 3` for better reliability
   - Increased memory limits for `fineract-server` (1Gi → 2Gi) to accommodate 
JVM heap + metaspace
   - Added explicit `-XX:MaxMetaspaceSize=256m` JVM option
   
   **Script improvements:**
   - Modernized `kubectl-startup.sh` to use `kubectl wait` instead of polling 
loops
   - Added `--ignore-not-found=true` to `kubectl-shutdown.sh` for idempotent 
cleanup
   - Added helpful output messages with access instructions and default 
credentials
   
   **Documentation:**
   - Updated README.md Minikube section with clearer instructions
   - Added `minikube service mifos-community` command for accessing the web UI
   - Documented default credentials (`mifos` / `password`)
   - Added log checking commands for both deployments
   
   ### Why:
   The previous Kubernetes configuration had issues running on Minikube with 
Docker driver on macOS. The web-app frontend couldn't reach the fineract-server 
backend due to network isolation. The nginx reverse proxy solution allows both 
frontend and API to be served from the same endpoint.
   
   ## Checklist
   
   - [x] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [x] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made.
     - *Note: These are infrastructure/deployment changes only, no application 
code changes. Tested manually on Minikube.*
   - [x] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [x] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
     - *N/A - No API changes, only Kubernetes deployment configuration.*
   - [x] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance. Ask for help on the 
[developer mailing list](https://fineract.apache.org/#contribute).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to