airajena opened a new pull request, #5265: URL: https://github.com/apache/fineract/pull/5265
## Description This PR addresses the TODO comment in [TemplateMergeService.java](cci:7://file:///C:/Users/airaj/OneDrive/Desktop/gsoc/fineract/fineract-provider/src/main/java/org/apache/fineract/template/service/TemplateMergeService.java:0:0-0:0) (line 58) that requested replacing the manual InputStream-to-String conversion with an appropriate alternative. ## Changes - Replace manual `BufferedReader`-based InputStream to String conversion with Java 11+ `InputStream.readAllBytes()` - Remove unused imports: `BufferedReader`, `InputStreamReader` - Reduces code from 15 lines to 8 lines ## Why This Approach The original TODO suggested using Guava, but Java 11+ provides native `InputStream.readAllBytes()` which: - Is cleaner and more readable - Is part of the standard library (no external dependency needed) - Handles encoding with `StandardCharsets.UTF_8` properly ## Testing - ✅ `./gradlew :fineract-provider:compileJava` passes - ✅ `./gradlew :fineract-provider:compileTestJava` passes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
