airajena commented on code in PR #5268:
URL: https://github.com/apache/fineract/pull/5268#discussion_r2649490612
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/serialization/CalendarCommandFromApiJsonDeserializer.java:
##########
@@ -153,11 +153,11 @@ public void validateForCreate(final String json) {
.inMinMaxRange(CalendarEntityType.getMinValue(),
CalendarEntityType.getMaxValue());
if
(this.fromApiJsonHelper.parameterExists(CalendarSupportedParameters.REPEATING.getValue(),
element)) {
- // FIXME - Throws NullPointerException when boolean value is null
- final boolean repeating =
this.fromApiJsonHelper.extractBooleanNamed(CalendarSupportedParameters.REPEATING.getValue(),
element);
+ // Fixed: Use Boolean wrapper to avoid NullPointerException when
value is null
Review Comment:
Thank you for the feedback! I've removed the explanatory comments .
Regarding the test failure: The failing test
SavingsInterestPostingTest.testSavingsInterestPosting_Works_ForMultipleAccounts()
is unrelated to my changes in the calendar module. It's failing due to an HTTP
401 authentication error in the CI test infrastructure. My changes only affect
CalendarCommandFromApiJsonDeserializer.java and
CalendarCommand.java in the calendar module - they don't touch the savings
API or authentication.
Could this be a flaky/infrastructure issue in the CI pipeline?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
