Monica-CodingWorld commented on code in PR #5279:
URL: https://github.com/apache/fineract/pull/5279#discussion_r2656355353
##########
fineract-command/src/test/java/org/apache/fineract/command/CommandBaseTest.java:
##########
@@ -40,9 +40,17 @@ abstract class CommandBaseTest {
protected static Network network = Network.newNetwork();
@Container
- protected static final GenericContainer POSTGRES_CONTAINER = new
GenericContainer("postgres:16").withNetwork(network)
- .withNetworkAliases("postgres").withExposedPorts(5432)
- .withEnv(Map.of("POSTGRES_DB", "fineract-test", "POSTGRES_USER",
"root", "POSTGRES_PASSWORD", "mifos"));
+ protected static final GenericContainer<?> POSTGRES_CONTAINER =
Review Comment:
The change in CommandBaseTest.java was committed because the test suite was
failing without explicitly setting the timezone. While working on the typo fix,
the tests exposed an existing instability caused by timezone differences
between environments.To ensure the build passes reliably and tests remain
deterministic across systems, the timezone configuration was added to the test
setup. This is a test infrastructure fix, not a functional or API change, found
it necessary to complete and validate the typo-related changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
