Aman-Mittal commented on code in PR #5279:
URL: https://github.com/apache/fineract/pull/5279#discussion_r2658810769
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/api/LoanProductsApiResourceSwagger.java:
##########
@@ -1662,7 +1662,7 @@ private PutLoanProductsProductIdRequest() {}
@Schema(example = "FULL_LEAP_YEAR")
public String daysInYearCustomStrategy;
@Schema(example = "true")
- public Boolean allowPartialPeriodInterestCalcualtion;
+ public Boolean allowPartialPeriodInterestCalculation;
@Schema(example = "179")
Review Comment:
Since this field appears to be part of the API surface, I think we should
retain tests for the legacy spelling alongside the corrected one to ensure
backward compatibility.
This would allow existing clients to continue working while validating the
new preferred field name.
If the old name is intentionally being dropped as a breaking change, that
should be explicitly documented.
while tests run ok when fixing all typos, it will bound to break lot of
things outside
I think backward compatibility must be added in this (As per Mail Thread).
TLDR; I think Old Test cases must be retained and new tests must be added
for fixed typo, so that it can be checked for both scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
