adamsaghy commented on code in PR #5219:
URL: https://github.com/apache/fineract/pull/5219#discussion_r2661236381
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/ProgressiveEMICalculator.java:
##########
@@ -1561,6 +1646,24 @@ private BigDecimal calculateFnResult(final
List<RepaymentPeriod> periods, final
.reduce(BigDecimal.ONE, (previousFnValue, currentRateFactor)
-> fnValue(previousFnValue, currentRateFactor, mc));//
}
+ /**
+ * Calculate Rate Factor Product from rate factors, filtering the first
period's interest periods by date. For Full
+ * Term Tranche calculations where a disbursement occurs mid-period, this
ensures only interest periods from the
+ * disbursement date are included.
+ */
+ private BigDecimal calculateRateFactorPlus1NFromDate(final
List<RepaymentPeriod> periods, final LocalDate fromDate,
Review Comment:
I dont think we need this either. The "addDisbursement" action should handle
all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]