Aman-Mittal commented on code in PR #5311:
URL: https://github.com/apache/fineract/pull/5311#discussion_r2693348684
##########
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/domain/Charge.java:
##########
@@ -755,23 +710,14 @@ public boolean isDisbursementCharge() {
||
ChargeTimeType.fromInt(this.chargeTimeType).equals(ChargeTimeType.TRANCHE_DISBURSEMENT);
}
- public TaxGroup getTaxGroup() {
- return this.taxGroup;
- }
-
- public void setTaxGroup(TaxGroup taxGroup) {
- this.taxGroup = taxGroup;
- }
-
@Override
public boolean equals(Object o) {
if (this == o) {
return true;
}
- if (!(o instanceof Charge)) {
+ if (!(o instanceof Charge other)) {
return false;
}
- Charge other = (Charge) o;
Review Comment:
Putting this in draft for conflict resolution, meanwhile for this change i
will reverting this logic back for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
