oleksii-novikov-onix commented on code in PR #5334:
URL: https://github.com/apache/fineract/pull/5334#discussion_r2699013089
##########
fineract-e2e-tests-runner/src/test/java/org/apache/fineract/test/initializer/global/LoanProductGlobalInitializerStep.java:
##########
@@ -3697,7 +3697,9 @@ public void initialize() throws Exception {
List<PostClassificationToIncomeAccountMappings>
buydownfeeClassificationToIncomeAccountMappings = new ArrayList<>();
PostClassificationToIncomeAccountMappings
classificationToIncomeAccountMappings = new
PostClassificationToIncomeAccountMappings();
-
classificationToIncomeAccountMappings.setClassificationCodeValueId(25L);
+ long classificationId =
codeValueResolver.resolve("buydown_fee_transaction_classification",
+ "buydown_fee_transaction_classification_value");
Review Comment:
We can use constants here
CodeNames.BUYDOWN_FEE_TRANSACTION_CLASSIFICATION.getValue() and
CodeGlobalInitializerStep.BUYDOWN_FEE_TRANSACTION_CLASSIFICATION_VALUE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
