vidakovic commented on PR #5338: URL: https://github.com/apache/fineract/pull/5338#issuecomment-3763979044
What is this!?!? Even if I assume this is done by you personally (I don't): - PR title not properly formatted - 11 commits vs squashing everything you did into 1 - over 300 files!?!? Just by the size of the files ADDED, never going to be reviewed - why a new package name?!? `ng.com.createsoftware.fn_account_service`, really? Snake-cased? Reminder: not a PHP project... just saying - just as an example why this PR can be considered malicious: https://github.com/apache/fineract/pull/5338/changes#diff-2dc260a81da76194aa57eecbff66cf0e8e895394399836565e01d765356c79f0R380 (disabling SSL? really?) - what's the purpose e.g. of https://github.com/apache/fineract/pull/5338/changes#diff-bc4827d9554ce8943edfa2369a6c28552408b8110d50415cdb55d5fcefbf2987R9 ? This code literally doesn't do anything! ... and I could go on and on. If this was an attempt to be funny: it's not. If this is your first attempt to write code: all these new AI engines out there might suggest that there are shortcuts... let me tell you: there is no replacement for learning stuff by yourself and then maybe add an AI tool later when you know what you are doing to help with some of the more tedious tasks. But this here? Is wasting people's time and dropping 300 non-sense files on a community of volunteers is not the proper way to introduce yourself (if that ever was your intention). If you really want to learn something then let us know... but this here is completely unacceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
