adamsaghy commented on code in PR #5224:
URL: https://github.com/apache/fineract/pull/5224#discussion_r2704721561


##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/ProgressiveEMICalculator.java:
##########
@@ -519,15 +519,21 @@ public PeriodDueDetails getDueAmounts(@NotNull 
ProgressiveLoanInterestScheduleMo
 
     @Override
     @NotNull
-    public Money getPeriodInterestTillDate(@NotNull 
ProgressiveLoanInterestScheduleModel scheduleModel, @NotNull LocalDate 
periodFromDate,
-            @NotNull LocalDate periodDueDate, @NotNull LocalDate targetDate, 
boolean includeCreditedInterest) {
-        ProgressiveLoanInterestScheduleModel recalculatedScheduleModelTillDate 
= recalculateScheduleModelTillDate(scheduleModel,
+    public Money getPeriodInterestTillDate(@NotNull final 
ProgressiveLoanInterestScheduleModel scheduleModel,

Review Comment:
   What is the purpose of the `fixedInterestTillDate` parameter? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to