adamsaghy commented on code in PR #5350:
URL: https://github.com/apache/fineract/pull/5350#discussion_r2707988404
##########
fineract-avro-schemas/src/main/avro/loan/v1/OriginatorDetailsV1.avsc:
##########
@@ -0,0 +1,62 @@
+{
+ "name": "OriginatorDetailsV1",
+ "namespace": "org.apache.fineract.avro.loan.v1",
+ "doc": "Loan originator details for revenue sharing and reporting",
+ "type": "record",
+ "fields": [
+ {
+ "default": null,
+ "name": "id",
+ "doc": "Internal originator ID",
+ "type": [
+ "null",
+ "long"
+ ]
+ },
+ {
+ "default": null,
+ "name": "externalId",
+ "doc": "Unique external identifier (Revenue Share ID)",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "name",
+ "doc": "Originator name",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "status",
+ "doc": "Originator status: ACTIVE, PENDING, or INACTIVE",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "originatorTypeId",
+ "doc": "Code value ID for originator type (MERCHANT, BROKER,
AFFILIATE, PLATFORM)",
+ "type": [
+ "null",
+ "long"
Review Comment:
Use `CodeValueDataV1` instead please.
##########
fineract-avro-schemas/src/main/avro/loan/v1/OriginatorDetailsV1.avsc:
##########
@@ -0,0 +1,62 @@
+{
+ "name": "OriginatorDetailsV1",
+ "namespace": "org.apache.fineract.avro.loan.v1",
+ "doc": "Loan originator details for revenue sharing and reporting",
+ "type": "record",
+ "fields": [
+ {
+ "default": null,
+ "name": "id",
+ "doc": "Internal originator ID",
+ "type": [
+ "null",
+ "long"
+ ]
+ },
+ {
+ "default": null,
+ "name": "externalId",
+ "doc": "Unique external identifier (Revenue Share ID)",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "name",
+ "doc": "Originator name",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "status",
+ "doc": "Originator status: ACTIVE, PENDING, or INACTIVE",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "originatorTypeId",
+ "doc": "Code value ID for originator type (MERCHANT, BROKER,
AFFILIATE, PLATFORM)",
+ "type": [
+ "null",
+ "long"
+ ]
+ },
+ {
+ "default": null,
+ "name": "channelTypeId",
+ "doc": "Code value ID for channel type (ONLINE, IN_STORE, API,
AGGREGATOR)",
+ "type": [
+ "null",
+ "long"
Review Comment:
Use `CodeValueDataV1` instead please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
