DeathGun44 commented on PR #5354: URL: https://github.com/apache/fineract/pull/5354#issuecomment-3774304479
> I don't like the "development" change. Because it is tied to a environment. It is prefer to add a new configuration file for this name and update the documentation. Thanks for the review @IOhacker. You make a valid point about keeping prometheus.yml environment-agnostic. The reason I made the change is that the docker-compose-development.yml file explicitly sets the container name to fineract-development, so the standard fineract-server hostname fails to resolve in the default dev stack. Alternative Proposal: Instead of creating a separate config file (which increases maintenance), would you prefer if I added a network alias to docker-compose-development.yml? If I add networks: aliases: - fineract-server to the fineract service, the standard prometheus.yml will work without modification. This i think could be cleaner than maintaining two separate Prometheus config files. Let me know if you agree, and I will update the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
