adamsaghy commented on code in PR #5336:
URL: https://github.com/apache/fineract/pull/5336#discussion_r2720798627
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookServiceImpl.java:
##########
@@ -245,17 +245,20 @@ public ImportData mapRow(final ResultSet rs,
@SuppressWarnings("unused") final i
public DocumentData getOutputTemplateLocation(String importDocumentId) {
this.securityContext.authenticatedUser();
final ImportTemplateLocationMapper importTemplateLocationMapper = new
ImportTemplateLocationMapper();
- final String sql = "select " + importTemplateLocationMapper.schema();
+ final String sql = "select " + importTemplateLocationMapper.schema() +
" where id = CAST(? AS BIGINT)";
Review Comment:
1. `importTemplateLocationMapper.schema()` already contains WHERE to filter.
This is incorrect.
2. The used syntax is for Postgres only, it would not work in mysql /
mariadb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
