adamsaghy commented on code in PR #5356:
URL: https://github.com/apache/fineract/pull/5356#discussion_r2721136760
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/ProgressiveLoanInterestRefundServiceImpl.java:
##########
@@ -118,9 +118,8 @@ private boolean
isTransactionNeededForInterestRefundCalculations(LoanTransaction
@Override
@Transactional(readOnly = true, propagation = Propagation.REQUIRES_NEW)
- public Money
totalInterestByTransactions(LoanRepaymentScheduleTransactionProcessor
processor, final Long loanId,
+ public Money
totalInterestByTransactions(LoanRepaymentScheduleTransactionProcessor
processor, final Loan loan,
Review Comment:
You cannot do that! We dont want to make any changes on Loan entity!
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/ProgressiveLoanInterestRefundServiceImpl.java:
##########
@@ -118,9 +118,8 @@ private boolean
isTransactionNeededForInterestRefundCalculations(LoanTransaction
@Override
@Transactional(readOnly = true, propagation = Propagation.REQUIRES_NEW)
- public Money
totalInterestByTransactions(LoanRepaymentScheduleTransactionProcessor
processor, final Long loanId,
+ public Money
totalInterestByTransactions(LoanRepaymentScheduleTransactionProcessor
processor, final Loan loan,
Review Comment:
You cannot do that! We dont want to make any changes on Loan entity!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
