adamsaghy commented on code in PR #5360:
URL: https://github.com/apache/fineract/pull/5360#discussion_r2721263308
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/ProgressiveLoanInterestScheduleModel.java:
##########
@@ -287,13 +289,8 @@ private void insertInterestPausePeriods(final
RepaymentPeriod repaymentPeriod, f
}
private InterestPeriod findPreviousInterestPeriod(final RepaymentPeriod
repaymentPeriod, final LocalDate date) {
- if (date.isAfter(repaymentPeriod.getFromDate())) {
- return repaymentPeriod.getLastInterestPeriod();
- } else {
- return repaymentPeriod.getInterestPeriods().stream()
- .filter(ip -> date.isAfter(ip.getFromDate()) &&
!date.isAfter(ip.getDueDate())).reduce((first, second) -> second)
- .orElse(repaymentPeriod.getInterestPeriods().getFirst());
- }
+ return repaymentPeriod.getInterestPeriods().stream().filter(ip ->
date.isAfter(ip.getFromDate()) && !date.isAfter(ip.getDueDate()))
+ .reduce((first, second) ->
second).orElse(repaymentPeriod.getInterestPeriods().getFirst());
Review Comment:
I think we are still missing 2 cases:
- If the date is on rp.getFromDate() -> use 1st interest period
- if the date is on rp.getduedate() -> use last interest period
otherwise use `repaymentPeriod.getInterestPeriods().stream().filter(ip ->
date.isAfter(ip.getFromDate()) && !date.isAfter(ip.getDueDate()))
.reduce((first, second) ->
second).orElse(repaymentPeriod.getInterestPeriods().getFirst());`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
