DeathGun44 opened a new pull request, #5384: URL: https://github.com/apache/fineract/pull/5384
## Description This PR refactors `GlobalConfigurationHelper.java` to fix a fragility issue where adding new global configurations to the database causes the integration test suite to crash with `IndexOutOfBoundsException`. **Changes:** * **Map-Based Lookup:** Replaced the fragile index-based iteration (parallel lists) with a robust `Map`-based lookup using configuration names. This prevents crashes when the database configuration count differs from the test harness default count. * **Strict Validation:** Implemented a strict check that throws a descriptive `RuntimeException` if a database configuration is missing from the test defaults. This prevents silent bypasses and directs developers to explicitly register new configurations to ensure test isolation. * **Preserved Logic:** Configuration reset logic (restoring values/enabled flags) remains behaviorally identical but is now order-independent and crash-proof. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
