DeathGun44 commented on code in PR #5387: URL: https://github.com/apache/fineract/pull/5387#discussion_r2725796142
########## fineract-provider/src/main/resources/db/changelog/tenant/parts/0208_add_force_password_reset_config.xml: ########## @@ -0,0 +1,55 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.3.xsd";> + <changeSet author="fineract" id="1"> + <addColumn tableName="m_appuser"> + <column name="password_reset_required" type="boolean" defaultValueBoolean="false"> + <constraints nullable="false"/> + </column> + </addColumn> + </changeSet> + + <changeSet author="fineract" id="2" context="postgresql"> Review Comment: Hi Victor, thank you for the review! I looked into this to be sure, and since the c_configuration table is defined with autoIncrement="true" in the initial schema, MariaDB and MySQL automatically handle the ID counter updates when we insert new rows. The setval command included here is specifically to manually sync the PostgreSQL sequence, which doesn't update automatically in the same way. I believe we don't need an equivalent step for MariaDB, but please let me know if you'd prefer I handle it differently! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
