Aman-Mittal commented on PR #5369: URL: https://github.com/apache/fineract/pull/5369#issuecomment-3797065137
dev (at) fineract (dot) apache (dot) org On Mon, 26 Jan, 2026, 12:01 am Aman Mittal, ***@***.***> wrote: > It's of fineract website you have to subscribe on your email > ***@***.*** > > On Sun, 25 Jan, 2026, 11:56 pm Aira Jena, ***@***.***> > wrote: > >> *airajena* left a comment (apache/fineract#5369) >> <https://github.com/apache/fineract/pull/5369#issuecomment-3797051464> >> >> I think it would be a good practice if we can implement a limiter on >> this. Like you can use forgot password at certain times. Within a span of >> interval. Like in every 5-10 minutes at a time for single user? >> … <#m_-3083136956501644212_m_-176778364799698856_m_-3566639483503118824_> >> On Sun, 25 Jan, 2026, 10:31 pm Aira Jena, *@*.*> wrote: airajena left a >> comment (apache/fineract#5369 >> <https://github.com/apache/fineract/pull/5369>) <#5369 (comment) >> <https://github.com/apache/fineract/pull/5369#issuecomment-3796957318>> >> Seems ok now, but really curious what type of safeguards are implemented in >> this, Additionally we need to tests for the code coverage Below things are >> on the safeguards side - The generated password is time-bound (24 hours). >> After expiry, it’s automatically invalid and cannot be used. - Once the >> user logs in using the temporary password, they are required to change it >> immediately, and the temporary credentials are cleared. - Any successful >> password update (either through this flow or via an admin action) >> invalidates the temporary password. - If email delivery fails, the >> transaction is rolled back so no orphaned temporary passwords are stored. - >> Password reset requests go through the service layer and are logged, so the >> activity is traceable — Reply to this email directly, view it on GitHub >> <#5369 (comment) >> <https://github.com/apache/fineract/pull/5369#issuecomment-3796957318>>, or >> unsubscribe >> https://github.com/notifications/unsubscribe-auth/AHV6TAZBOYWXIQOMB2PGVW34ITZHRAVCNFSM6AAAAACSUFDBTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOOJWHE2TOMZRHA >> <https://github.com/notifications/unsubscribe-auth/AHV6TAZBOYWXIQOMB2PGVW34ITZHRAVCNFSM6AAAAACSUFDBTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOOJWHE2TOMZRHA> >> . You are receiving this because you commented.Message ID: @.*> >> >> I didn’t include it in this PR to keep the scope limited to the core >> “forgot password” functionality and avoid introducing additional >> persistence or infrastructure concerns. That said, I think this is >> definitely worth addressing. I’m happy to raise a follow-up JIRA ticket and >> work on the rate-limiting implementation separately so we can design it >> cleanly without blocking this feature. Let me know if that approach works >> for you. Also I wanted to ask one thing, is there any slack channel that I >> can get access for discussions? >> >> — >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/fineract/pull/5369#issuecomment-3797051464>, >> or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AHV6TA4CORFA5SHHOOVEC3D4IUDE7AVCNFSM6AAAAACSUFDBTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOOJXGA2TCNBWGQ> >> . >> You are receiving this because you commented.Message ID: >> ***@***.***> >> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
