adamsaghy commented on code in PR #5396:
URL: https://github.com/apache/fineract/pull/5396#discussion_r2732173710
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/ProgressiveEMICalculator.java:
##########
@@ -138,7 +138,8 @@ private void addDisbursement(final
ProgressiveLoanInterestScheduleModel schedule
.forEach(rp ->
rp.setTotalDisbursedAmount(rp.getTotalDisbursedAmount().add(operation.getAmount())));
final int numberOfRepayments =
scheduleModel.loanProductRelatedDetail().getNumberOfRepayments();
- if
(scheduleModel.loanProductRelatedDetail().isAllowFullTermForTranche() &&
numberOfRepayments > 0) {
+ if
(scheduleModel.loanProductRelatedDetail().isAllowFullTermForTranche() &&
numberOfRepayments > 0
+ &&
operation.getAction().equals(EmiChangeOperation.Action.DISBURSEMENT)) {
Review Comment:
Do we need this operation action check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
