Aman-Mittal commented on code in PR #5403:
URL: https://github.com/apache/fineract/pull/5403#discussion_r2735548871
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/shareaccounts/serialization/ShareAccountDataSerializer.java:
##########
@@ -708,7 +708,7 @@ public Map<String, Object>
validateAndApplyAddtionalShares(JsonCommand jsonComma
boolean isTransactionBeforeExistingTransactions = false;
Set<ShareAccountTransaction> transactions =
account.getShareAccountTransactions();
for (ShareAccountTransaction transaction : transactions) {
- if (!transaction.isChargeTransaction()) {
+ if (!transaction.isChargeTransaction() && transaction.isActive()) {
Review Comment:
Can you please tell me what is the current object for transaction rejected
and reversed transaction, I think we can add unit tests for these case where
when we perform transaction with reversed and rejected transaction it will work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
