Saifulhuq01 commented on PR #5417: URL: https://github.com/apache/fineract/pull/5417#issuecomment-3827489620
> These changes really improved the code, but in my opinion it would be much more beneficial to rewrite it from jdbcTemplate to Spring Data JPA. Thank you for the review! I agree that moving to Spring Data JPA is the better long-term architectural goal. However, since this PR is focused on a critical Security Fix (SQL Injection), I would prefer to keep the scope limited to jdbcTemplate for now to ensure a faster merge. I can open a separate Jira ticket to handle the JPA migration as a follow-up task. Does that sound reasonable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
