meonkeys commented on code in PR #45:
URL: https://github.com/apache/fineract-site/pull/45#discussion_r2749914682
##########
index.html:
##########
@@ -1078,6 +1078,9 @@ <h3 class="white-text center-align">Reference</h3>
<a href="https://www.apache.org/events/current-event.html";
target="_blank">
<img
src="https://www.apache.org/events/current-event-234x60.png"; alt="Apache
Current Event"/>
</a>
+ <a href="https://app.digitalpublicgoods.net/a/10206";
target="_blank">
+ <img
src="raw.githubusercontent.com/DPGAlliance/dpg-resources/main/dpg-badge.svg"alt="Digital
Public Goods Badge"width="200"/>
Review Comment:
another broken link!
`raw.githubusercontent.com/DPGAlliance/dpg-resources/main/dpg-badge.svg`
redirects to
`https://raw.githubusercontent.com/DPGAlliance/dpg-resources/main/dpg-badge.svg`
and trying to fetch that gives me a HTTP 404 - not found.
also shouldn't it start with `https://`? Or maybe `://`? I forget what the
best practice is these days. Maybe just `https://` since we know that works and
we might as well default to encouraging clients to encrypt traffic
also how about a space before `alt`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://www.apache.org/events/current-event-234x60.png"](https://www.apache.org/events/current-event-234x60.png"){kind=link}
