DeathGun44 opened a new pull request, #5432: URL: https://github.com/apache/fineract/pull/5432
## Description This PR addresses [FINERACT-2449](https://issues.apache.org/jira/browse/FINERACT-2449). ### Background The current `SimpleAsyncTaskExecutor` creates a new thread for every task. While effective for light loads, this unbounded behavior poses a theoretical risk of thread exhaustion (`OutOfMemoryError: unable to create native thread`) under specific high-concurrency scenarios. ### Motivation Relying on an unbounded executor is contrary to Spring Boot best practices for production-grade financial systems. This change proactively addresses the risk before it manifests in production. ### Solution | Component | Change | |-----------|--------| | [SpringConfig.java](cci:7://file:///home/deathgun/fineract/fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/config/SpringConfig.java:0:0-0:0) | Replace `SimpleAsyncTaskExecutor` with `ThreadPoolTaskExecutor` | | [FineractProperties.java](cci:7://file:///home/deathgun/fineract/fineract-core/src/main/java/org/apache/fineract/infrastructure/core/config/FineractProperties.java:0:0-0:0) | Add `eventTaskExecutorCorePoolSize` and `eventTaskExecutorMaxPoolSize` | | [application.properties](cci:7://file:///home/deathgun/fineract/fineract-provider/src/main/resources/application.properties:0:0-0:0) | Add externalized config with CPU-aware defaults | ### Testing [SpringConfigTest.java](cci:7://file:///home/deathgun/fineract/fineract-provider/src/test/java/org/apache/fineract/infrastructure/core/config/SpringConfigTest.java:0:0-0:0) (Added 8 unit tests proving bounded behavior) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
