adamsaghy commented on code in PR #5380:
URL: https://github.com/apache/fineract/pull/5380#discussion_r2755502060
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/EMICalculator.java:
##########
@@ -26,35 +26,36 @@
import java.util.Optional;
import org.apache.fineract.organisation.monetary.domain.MonetaryCurrency;
import org.apache.fineract.organisation.monetary.domain.Money;
-import
org.apache.fineract.portfolio.loanaccount.domain.LoanRepaymentScheduleInstallment;
-import org.apache.fineract.portfolio.loanaccount.domain.LoanTransaction;
-import
org.apache.fineract.portfolio.loanaccount.domain.reaging.LoanReAgeParameter;
import
org.apache.fineract.portfolio.loanaccount.loanschedule.domain.LoanApplicationTerms;
-import
org.apache.fineract.portfolio.loanaccount.loanschedule.domain.LoanScheduleModelRepaymentPeriod;
import
org.apache.fineract.portfolio.loanproduct.calc.data.EqualAmortizationValues;
+import
org.apache.fineract.portfolio.loanproduct.calc.data.LoanReAgeParameterData;
import org.apache.fineract.portfolio.loanproduct.calc.data.OutstandingDetails;
import org.apache.fineract.portfolio.loanproduct.calc.data.PeriodDueDetails;
+import
org.apache.fineract.portfolio.loanproduct.calc.data.ProcessedTransactionData;
import
org.apache.fineract.portfolio.loanproduct.calc.data.ProgressiveLoanInterestScheduleModel;
import org.apache.fineract.portfolio.loanproduct.calc.data.RepaymentPeriod;
+import
org.apache.fineract.portfolio.loanproduct.calc.data.RepaymentScheduleInstallmentData;
+import
org.apache.fineract.portfolio.loanproduct.calc.data.ScheduleModelPeriodData;
import
org.apache.fineract.portfolio.loanproduct.domain.ILoanConfigurationDetails;
public interface EMICalculator {
/**
* This method creates an Interest model with repayment periods from the
schedule periods which generated by
- * schedule generator.
+ * schedule generator. Use EMICalculatorDataMapper to convert
LoanScheduleModelRepaymentPeriod to
+ * ScheduleModelPeriodData before calling this method.
*/
@NotNull
- ProgressiveLoanInterestScheduleModel
generatePeriodInterestScheduleModel(@NotNull
List<LoanScheduleModelRepaymentPeriod> periods,
Review Comment:
`LoanScheduleModelRepaymentPeriod` is already a DTO. the only required
changes is to move away from using `LoanInterestRecalcualtionAdditionalDetails`
inside...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
