airajena commented on code in PR #5383:
URL: https://github.com/apache/fineract/pull/5383#discussion_r2759421820
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/DefaultLoanLifecycleStateMachine.java:
##########
@@ -154,7 +154,8 @@ private LoanStatus getNextStatus(LoanEvent loanEvent, Loan
loan) {
break;
case LOAN_CHARGE_PAYMENT:
case LOAN_REPAYMENT_OR_WAIVER, LOAN_CHARGEBACK:
- if (anyOfAllowedWhenComingFrom(from,
LoanStatus.CLOSED_OBLIGATIONS_MET, LoanStatus.OVERPAID)) {
+ if (anyOfAllowedWhenComingFrom(from,
LoanStatus.CLOSED_OBLIGATIONS_MET, LoanStatus.OVERPAID,
Review Comment:
Yes, I reviewed it, using LOAN_REPAYMENT_OR_WAIVER / LOAN_OVERPAYMENT to
drive the transfer completion transition is semantically wrong, so I fixed it
properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
