airajena commented on code in PR #5337:
URL: https://github.com/apache/fineract/pull/5337#discussion_r2762308174
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/note/api/NotesApiResource.java:
##########
@@ -54,7 +54,7 @@
import org.apache.fineract.portfolio.note.service.NoteReadPlatformService;
import org.springframework.stereotype.Component;
-@Path("/v1/{resourceType}/{resourceId}/notes")
+@Path("/v1/{resourceType:.+}/{resourceId}/notes")
Review Comment:
I've added .{+} because the new note types include a path segment in
resourceType (accounts/share). With the old path
@Path("/v1/{resourceType}/{resourceId}/notes"), Jersey treats only the first
segment as resourceType, so accounts/share/... never matched the Notes API and
returned 400. Using @Path("/v1/{resourceType:.+}/{resourceId}/notes") allows
resourceType to capture multi‑segment values like accounts/share, while still
keeping the rest of the route intact. It’s scoped only to this resource and
doesn’t affect other endpoints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
