Saifulhuq01 commented on code in PR #5438:
URL: https://github.com/apache/fineract/pull/5438#discussion_r2773410549
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/service/LoanScheduleAssembler.java:
##########
@@ -748,18 +750,10 @@ public LoanScheduleModel assembleLoanScheduleFrom(final
LoanApplicationTerms loa
final MathContext mc = MoneyHelper.getMathContext();
HolidayDetailDTO detailDTO = new HolidayDetailDTO(isHolidayEnabled,
holidays, workingDays);
- LoanScheduleGenerator loanScheduleGenerator =
this.loanScheduleFactory.create(loanApplicationTerms.getLoanScheduleType(),
- loanApplicationTerms.getInterestMethod());
+ // REFACTORED: Removed redundant initialization and extracted logic
Review Comment:
> We dont want such comments. Please remove
done @adamsaghy kindly check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
