DeathGun44 opened a new pull request, #5460: URL: https://github.com/apache/fineract/pull/5460
## Description This PR adds validation integration tests for Credit Bureau Configuration APIs (FINERACT-2116). Tests cover: - Credit Bureau Configuration: missing/blank/exceeding length for `configkey`, `value`, `description` - Organisation Credit Bureau: missing/blank/exceeding length for `alias` - Loan Product Mapping: missing `loanProductId`, `isCreditcheckMandatory`, `skipCreditcheckInFailure`, `stalePeriod` > [!IMPORTANT] > **Dependency:** This PR includes a test for missing `loanProductId` validation which will fail until #5457 is merged. That PR fixes the NPE that causes a 500 error instead of 400 validation error. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions) - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
