SavvyPabi commented on PR #3909: URL: https://github.com/apache/fineract/pull/3909#issuecomment-3873718396
Hi @adamsaghy @vidakovic Great work on this restructure! Now that the foundational cleanup for loan creation/modification is merged, I wanted to share a Product Perspective on the logical next steps for the validation layer. To build on this new structure, I suggest we look at standardizing our Business Validation & Rejection logic: Standardized Reason Codes: Moving from generic strings to specific codes, so front-end apps can provide clearer user guidance. Audit Persistence: Ensuring that "Rejected" or "Draft" attempts are logged in the audit trail rather than discarded—a major requirement for banking compliance. Tiered Validation: Implementing a "fail-fast" approach (Technical/Schema checks first, then Business Policy) to optimize performance for high-volume environments. I'm happy to help document a set of Standardized Business Reason Codes that align with international microfinance standards if that helps the post-refactor roadmap! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
