Dhanno98 opened a new pull request, #5470: URL: https://github.com/apache/fineract/pull/5470
## Description Implements [FINERACT-2408](https://issues.apache.org/jira/browse/FINERACT-2408): This PR adds `entityStatus` mapping for **SAVING** and **SHARE** entities in the search API. The `/v1/search` endpoint returned an empty `entityStatus` for entities of type **SAVING** and **SHARE**. This happened because `SearchMapper.mapRow()` in `SearchReadPlatformServiceImpl` did not contain handling for these entity types, so the status defaulted to an empty `EnumOptionData`. ## Solution Added missing mappings in `SearchMapper.mapRow()`: 1. For **SAVING** entity types: - Get the `SavingsAccountStatusEnumData` using `SavingsEnumerations.status()`. - Convert it to `EnumOptionData` using the status data's id, code, and value. 2. For **SHARE** entity types: - Get the `ShareAccountStatusEnumData` using `SharesEnumerations.status()`. - Convert it to `EnumOptionData` using the status data's id, code, and value. To support this conversion, overloaded `status()` methods are introduced in `SavingsEnumerations` and `SharesEnumerations`. ## Result Search results for **SAVING** and **SHARE** entities now return the correct `entityStatus` instead of empty values. ## Verification ### Before Fix <img width="1920" height="919" alt="Before" src="https://github.com/user-attachments/assets/a28165e5-caa3-4bcf-b523-fc10e8812e40"; /> ### After Fix <img width="1920" height="920" alt="After" src="https://github.com/user-attachments/assets/3224b543-e826-4b5b-8c61-468eba60bef3"; /> ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
