edk12564 opened a new pull request, #5473: URL: https://github.com/apache/fineract/pull/5473
FINERACT-176 fixed missing throw exception in Teller module - Fixed missing throw exception for validation errors in Teller Module ReportedBy: subramanyasn ## Issue Before any changes, the backend was returning a error.msg.teller.unknown.data.integrity.issue when there is no input on cash transactions in the teller module. This was because the error was being built in the validator, but there was no throw statement. I verified this by testing on a dev server, where notably the issue was handled by the frontend by the Submit button being greyed out. However, we should still handle this in the backend. <img width="638" height="821" alt="Screenshot 2026-02-10 at 4 38 52 PM" src="https://github.com/user-attachments/assets/873c0897-ba25-47cc-9be4-f175f1994110"; /> I also verified using Postman, and replicated the issue on the backend. <img width="842" height="592" alt="Screenshot 2026-02-10 at 4 44 18 PM" src="https://github.com/user-attachments/assets/f8806769-0e7d-4449-8134-ece9ea6cbf19"; /> Here is the proper validation with error as expected. <img width="863" height="668" alt="Screenshot 2026-02-10 at 5 23 58 PM" src="https://github.com/user-attachments/assets/69fb6628-f6e5-401e-9b3d-dee62fd6795a"; /> More on this here: https://issues.apache.org/jira/browse/FINERACT-176 ## Fix Added throwExceptionIfValidationWarningsExist(() to the validateForCashTxnForCashier method in the TellerCommandFromApiJsonDeserializer. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
