rhopman opened a new pull request, #5493:
URL: https://github.com/apache/fineract/pull/5493
The status field in StandingInstructionData.java is missing the `@Getter`
annotation, causing it to be excluded from JSON serialization even though it's
properly selected from the database and populated by the
`StandingInstructionMapper`.
This causes API responses from `GET /standinginstructions` to omit the
status field, making it impossible for frontend applications to:
Filter out deleted standing instructions (status=3)
Distinguish between ACTIVE (1), DISABLED (2), and DELETED (3) states
Provide proper UI feedback about standing instruction states
## Checklist
- [X] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [X] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [X] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [X] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [X] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [X] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
