IOhacker commented on PR #5498: URL: https://github.com/apache/fineract/pull/5498#issuecomment-3903575755
Hello, I would go for consolidating everything in one single commit/PR Best regards Victor El dom, 15 feb 2026 a las 1:27, Ashhar Ahmad Khan ***@***.***>) escribió: > *AshharAhmadKhan* left a comment (apache/fineract#5498) > <https://github.com/apache/fineract/pull/5498#issuecomment-3903536058> > > Hi @IOhacker <https://github.com/IOhacker>, > > Thank you for reviewing this and for the feedback. > > I structured the work in phases to keep each change small and easier to > review, but I understand the preference for a single PR. I’m happy to align > with whatever approach is preferred for the project. > > Would you recommend consolidating everything related to FINERACT-2480 > <https://issues.apache.org/jira/browse/FINERACT-2480> into one PR, or > keeping it as a single PR with logically separated commits for clarity? > > Please let me know the preferred direction and I’ll adjust accordingly. > > Thanks again for your guidance. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/fineract/pull/5498#issuecomment-3903536058>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALD2ZAWPZNJWZHW2NOWVOPT4MANUZAVCNFSM6AAAAACVFPOEUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMBTGUZTMMBVHA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
