Kenzy-Ragab commented on PR #5501: URL: https://github.com/apache/fineract/pull/5501#issuecomment-3911423073
Hi @IOhacker, Thank you for the guidance. I'm currently refining the SQL to be more explicit as requested. However, I have a quick architectural question before I push the final list: Given that we have over 40+ Pentaho-related entries (between reports and permissions), listing them all explicitly in the IN clause will make the Liquibase script quite lengthy and harder to maintain if any similar legacy data is found later. What do you think of this balanced approach? - Use the Pattern for permissions: LIKE 'READ_%_PENTAHO' (since they all follow this unique naming convention). - Use the Category for reports: report_category = 'Pentaho'. - I will add a detailed XML comment above the changeSet listing the major reports being removed as a reference for future developers. This keeps the code clean and DRY while remaining explicit about the target group. Or would you prefer every single report name to be hardcoded in the script for maximum safety? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
