adamsaghy commented on code in PR #5454:
URL: https://github.com/apache/fineract/pull/5454#discussion_r2816563359


##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsHelper.java:
##########
@@ -138,11 +171,11 @@ private LocalDate 
determineInterestPostingPeriodEndDateFrom(final LocalDate peri
                         break;
                     }
                 }
-
                 if (!isEndDateSet) {
-                    periodEndDate = 
quarterlyDates.get(0).plusYears(1).with(TemporalAdjusters.lastDayOfMonth());

Review Comment:
   why did you removed this?



##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsHelper.java:
##########
@@ -151,38 +184,47 @@ private LocalDate 
determineInterestPostingPeriodEndDateFrom(final LocalDate peri
                         break;
                     }
                 }
-
                 if (!isEndDateSet) {
-                    periodEndDate = 
biannualDates.get(0).plusYears(1).with(TemporalAdjusters.lastDayOfMonth());

Review Comment:
   why did you removed this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to