adamsaghy commented on code in PR #5441:
URL: https://github.com/apache/fineract/pull/5441#discussion_r2816748765
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/RepaymentPeriod.java:
##########
@@ -273,6 +276,24 @@ public Money getDueInterest() {
return dueInterestCalculation.get();
}
+ private boolean isInterestPaymentGracePeriod() {
+ Integer interestGrace =
loanProductRelatedDetail.getGraceOnInterestPayment();
+ if (interestGrace == null || interestGrace <= 0) {
+ return false;
+ }
+ return getPeriodNumber() <= interestGrace;
+ }
+
+ private int getPeriodNumber() {
Review Comment:
Interesting approach, but i think we should do it differently.
Based on the configuration let's use modifier flags which will instruct the
calculator whether interest can be calculated or not.
The interest pause logic which is already in place can be rather used here
to achieve the same! :)
I think the right approach anyway would be to consider the grace principal
and grace interest from the moment it was generated and the EMI should consider
and reflect them from Day 1.
@bharathc27 what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
