adamsaghy commented on code in PR #5500:
URL: https://github.com/apache/fineract/pull/5500#discussion_r2816781818


##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/savings/SavingsAccountHelper.java:
##########
@@ -1293,6 +1294,31 @@ public static Integer openSavingsAccount(final 
RequestSpecification requestSpec,
         return savingsId;
     }
 
+    // TODO: Rewrite to use fineract-client instead!
+    // Example: 
org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long,
+    // org.apache.fineract.client.models.PostLoansLoanIdRequest)
+    @Deprecated(forRemoval = true)
+    public static Integer openGroupSavingsAccount(final RequestSpecification 
requestSpec, final ResponseSpecification responseSpec,

Review Comment:
   Please dont introduce new functionalities which are not using the 
fineract-client framework!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to