This is an automated email from the ASF dual-hosted git repository. meonkeys pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/fineract-chat-archive.git
commit cddce07f3e85881ecf8cf79dd05b922b217b7393 Author: Adam Monsen <[email protected]> AuthorDate: Tue Feb 17 12:52:10 2026 -0800 fix unit test also, use UTF-8 glyphs in mock data and UTF-16BE codepoints in assertion --- src/main/java/org/apache/fineract/chat/archive/HtmlRenderer.java | 2 +- .../java/org/apache/fineract/chat/archive/HtmlRendererTest.java | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/apache/fineract/chat/archive/HtmlRenderer.java b/src/main/java/org/apache/fineract/chat/archive/HtmlRenderer.java index cb395e1..0334872 100644 --- a/src/main/java/org/apache/fineract/chat/archive/HtmlRenderer.java +++ b/src/main/java/org/apache/fineract/chat/archive/HtmlRenderer.java @@ -175,7 +175,7 @@ final class HtmlRenderer { if (row.reactions() != null && !row.reactions().isEmpty()) { builder.append("<div class=\"archive-reactions\">"); for (String reaction : row.reactions()) { - builder.append("<span class=\"archive-reaction\">\n") + builder.append("<span class=\"archive-reaction\">") .append(escapeHtml(normalize(reaction))) .append("</span>\n"); } diff --git a/src/test/java/org/apache/fineract/chat/archive/HtmlRendererTest.java b/src/test/java/org/apache/fineract/chat/archive/HtmlRendererTest.java index 7414683..8192547 100644 --- a/src/test/java/org/apache/fineract/chat/archive/HtmlRendererTest.java +++ b/src/test/java/org/apache/fineract/chat/archive/HtmlRendererTest.java @@ -32,12 +32,12 @@ class HtmlRendererTest { List<HtmlRenderer.Row> rows = List.of( new HtmlRenderer.Row(false, "Thu 09:15", "Thu, 12 Feb 2026 09:15:00 GMT", "alex", "Thread root with <a class=\"archive-link\" href=\"https://example.org\";>link</a>", - "https://slack.example/permalink";, List.of("\uD83D\uDC4D 1")), + "https://slack.example/permalink";, List.of("👍 1")), new HtmlRenderer.Row(true, "Thu 09:16", "Thu, 12 Feb 2026 09:16:00 GMT", "sam", "_Okay_\n*Passed ?*\n~Maybe~\n- Check\n- LFG", - "https://slack.example/permalink2";, List.of("\uD83D\uDC4B 2")), + "https://slack.example/permalink2";, List.of("👋 2")), new HtmlRenderer.Row(true, "Thu 09:18", "Thu, 12 Feb 2026 09:18:00 GMT", - "jo", "Looks good \uD83D\uDC4D", "https://slack.example/permalink3";, + "jo", "Looks good 👍", "https://slack.example/permalink3";, List.of())); String page = HtmlRenderer.renderDailyPage("fineract", LocalDate.parse("2026-02-12"), rows); @@ -56,6 +56,8 @@ class HtmlRendererTest { assertTrue(page.contains("<ul class=\"archive-list\">")); assertTrue(page.contains("<li>Check</li>")); assertTrue(page.contains("class=\"archive-reactions\"")); + // intentionally left UTF-16BE "thumbs up" codepoint here to confirm we + // used the correct UTF-8 emoji glyph above assertTrue(page.contains("class=\"archive-reaction\">\uD83D\uDC4D 1</span>")); assertTrue(page.contains("href=\"../../../assets/chat-archive.css\"")); assertFalse(page.contains("permalink:"));
