adamsaghy commented on code in PR #5512: URL: https://github.com/apache/fineract/pull/5512#discussion_r2822161360
########## fineract-working-capital-loan/src/main/resources/jpa.static-weaving.module.fineract-working-capital-loan/persistence.xml: ########## @@ -0,0 +1,156 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> + + +<persistence version="2.0" + xmlns="http://java.sun.com/xml/ns/persistence"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://java.sun.com/xml/ns/persistence http://java.sun.com/xml/ns/persistence/persistence_2_0.xsd";> + + <!-- This file is only used for static weaving, nothing more. --> + <!-- You can find the runtime configuration in the JPAConfig class --> + <persistence-unit name="jpa-pu" transaction-type="RESOURCE_LOCAL"> + <provider>org.eclipse.persistence.jpa.PersistenceProvider</provider> + + <!-- Core Module Entities --> Review Comment: I worked ahead a little bit. For static weaving all entities which are used in this module shall be listed. It's quite easy to forget, so we had these curated lists about the available entities in the modules and they are just simply listed, even if they are not used. My 2 cents were "no harm was done" and its quite easy just copy-paste. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
