Aman-Mittal commented on code in PR #5511: URL: https://github.com/apache/fineract/pull/5511#discussion_r2823179778
########## fineract-mix/dependencies.gradle: ########## @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +dependencies { + // Never use "compile" scope, but make all dependencies either 'implementation', 'runtimeOnly' or 'testCompile'. + // Note that we never use 'api', because Fineract at least currently is a simple monolithic application ("WAR"), not a library. + // We also (normally should have) no need to ever use 'compileOnly'. + + // implementation dependencies are directly used (compiled against) in src/main (and src/test) + // + implementation( + project(path: ':fineract-core'), + project(path: ':fineract-command'), + ) + + implementation( + 'org.springframework.boot:spring-boot-starter-web', + 'org.springframework.boot:spring-boot-starter-validation', + 'org.springframework.boot:spring-boot-starter-security', + 'org.springframework.boot:spring-boot-starter-data-jdbc', + 'jakarta.ws.rs:jakarta.ws.rs-api', + 'org.glassfish.jersey.media:jersey-media-multipart', + 'com.fasterxml.jackson.core:jackson-databind', + + 'org.apache.commons:commons-lang3', + + 'com.google.guava:guava', + // TODO: try to get rid of this as soon as we get hands on the MIX XSD file from 2009; then we can use JAXB + 'com.google.code.gson:gson', + + 'com.github.spotbugs:spotbugs-annotations', + 'io.swagger.core.v3:swagger-annotations-jakarta', + + 'org.mapstruct:mapstruct', + + 'io.github.resilience4j:resilience4j-spring-boot3', + 'org.apache.httpcomponents:httpcore', + + 'org.apache.tika:tika-core', + 'org.apache.tika:tika-parser-microsoft-module', + 'org.apache.tika:tika-parser-miscoffice-module', + 'org.apache.tika:tika-parser-image-module', + ) + compileOnly 'org.projectlombok:lombok' + annotationProcessor 'org.projectlombok:lombok' + annotationProcessor 'org.mapstruct:mapstruct-processor' + implementation('org.apache.commons:commons-csv'){} + implementation ('software.amazon.awssdk:s3') { + } + implementation ('software.amazon.awssdk:auth') { + } Review Comment: I can't understand using this dependency software.amazon.awssdk, My concern is that it ties project directly to AWS, i think we can make this vendor neutral. like a switchable plug and play dependency if we can switch between gcp, azure, aws or even self host alternative? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
