rhopman opened a new pull request, #5519: URL: https://github.com/apache/fineract/pull/5519
Add GROUP (type ID 4) as a new guarantor type to support using group savings accounts as loan collateral. Previously, the system only supported CLIENT (1), STAFF (2), and EXTERNAL (3) guarantor types, which caused validation failures when attempting to use group savings accounts as guarantors. This resolves the issue where `testOnHoldTransactionsApiForGroupSavingsAccount` was incorrectly using CLIENT type with a group entity ID, and enables proper use of group accounts as loan collateral throughout the system. ## Checklist - [X] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [X] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [X] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [X] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
