edk12564 commented on code in PR #5437: URL: https://github.com/apache/fineract/pull/5437#discussion_r2828869002
########## .github/workflows/pr-one-commit-per-user-check.yml: ########## @@ -0,0 +1,57 @@ +name: Fineract PR One Commit Per User Check + + +on: Review Comment: I see what you mean with the target! To test this out, I did some investigating on my local fork where I submitted a PR into my own fork's develop branch. My setup is: the develop branch has pr-one-commit-per-user.yml and the PR branch does not. I first tested with multiple commits at once, and it properly failed. I also tested the target by squashing my commits in the PR, and the test passed. From the results, it seems to properly target the PR branch, but runs the pull_request_target scripts that live in the develop branch. Some pictures below. no script in PR: <img width="1377" height="767" alt="Screenshot 2026-02-19 at 9 33 10 AM" src="https://github.com/user-attachments/assets/2167a838-71fa-4be1-8651-4b1055bb7574"; /> failed test: <img width="1074" height="805" alt="Screenshot 2026-02-19 at 9 47 47 AM" src="https://github.com/user-attachments/assets/141d9b7a-c5d0-4f31-803a-b1ea8ba85385"; /> success test: <img width="1147" height="729" alt="Screenshot 2026-02-19 at 10 25 21 AM" src="https://github.com/user-attachments/assets/e5fd59a7-f687-471f-a09d-4626ef701ee6"; /> I think based on this, this one particular PR will not have checks applied. However, if it is merged into the develop branch, any future PR will still be checked, and target the actual PR branch, and not the apache/fineract repo. However, the problem of running without workflow permissions isn't a big issue, so I think we can definitely go either way. Please let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
