Aman-Mittal commented on code in PR #5510:
URL: https://github.com/apache/fineract/pull/5510#discussion_r2836486075
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/api/ApiParameterHelper.java:
##########
@@ -138,4 +147,24 @@ public static boolean genericResultSet(final
MultivaluedMap<String, String> quer
public static boolean genericResultSetPassed(final MultivaluedMap<String,
String> queryParams) {
return queryParams.getFirst(GENERIC_RESULT_SET) != null;
}
+
+ public static Integer extractLimitParameter(MultivaluedMap<String, String>
queryParameters) {
+ Objects.requireNonNull(queryParameters, "queryParameters map cannot be
null");
+ String limit = queryParameters.getFirst("limit");
+ return (StringUtils.isNotBlank(limit)) ? Integer.valueOf(limit.trim())
: null;
Review Comment:
/home/runner/work/fineract/fineract/fineract-validation/src/main/java/org/apache/fineract/validation/constraints/EnumValueValidator.java:33:
warning: [StringCaseLocaleUsage] Specify a `Locale` when calling
`String#to{Lower,Upper}Case`. (Note: there are multiple suggested fixes; the
third may be most appropriate if you're dealing with ASCII Strings.)
acceptedValues =
Arrays.stream(annotation.enumClass().getEnumConstants()).map(e ->
e.name().toLowerCase())
^
(see https://errorprone.info/bugpattern/StringCaseLocaleUsage)
Did you mean 'acceptedValues =
Arrays.stream(annotation.enumClass().getEnumConstants()).map(e ->
e.name().toLowerCase(Locale.ROOT))' or 'acceptedValues =
Arrays.stream(annotation.enumClass().getEnumConstants()).map(e ->
e.name().toLowerCase(Locale.getDefault()))' or 'acceptedValues =
Arrays.stream(annotation.enumClass().getEnumConstants()).map(e ->
Ascii.toLowerCase(e.name()))'?
/home/runner/work/fineract/fineract/fineract-validation/src/main/java/org/apache/fineract/validation/constraints/EnumValueValidator.java:39:
warning: [StringCaseLocaleUsage] Specify a `Locale` when calling
`String#to{Lower,Upper}Case`. (Note: there are multiple suggested fixes; the
third may be most appropriate if you're dealing with ASCII Strings.)
return value != null && acceptedValues.contains(value.toLowerCase());
^
(see https://errorprone.info/bugpattern/StringCaseLocaleUsage)
Did you mean 'return value != null &&
acceptedValues.contains(value.toLowerCase(Locale.ROOT));' or 'return value !=
null && acceptedValues.contains(value.toLowerCase(Locale.getDefault()));' or
'return value != null && acceptedValues.contains(Ascii.toLowerCase(value));'?
3 warnings
Unable to resolve POM for org.eclipse.platform:org.eclipse.swt:3.124.100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
