AliRana30 commented on PR #54:
URL: https://github.com/apache/fineract-site/pull/54#issuecomment-3981134592
@meonkeys Apologies for getting late. I was working hard to resolve all your
concerns and bugs.
Here are all before after changes for this PR :
## What changed
- Added CSS variables for light/dark theme with WCAG 2.1 AA compliant colors
(`--link-color: #00796B` light, `#4db6ac` dark)
- Fixed 130+ contrast failures: headings, body text, links, chips, buttons,
card panels, collection items in both modes
- Added `@media (prefers-color-scheme: dark)` + `[data-theme="dark"]` full
dark mode support (addresses Aira's theme-switch PR #50 gap — system preference
now works correctly)
- Fixed icon-text alignment in About/Contribute/mailing sections with
flexbox (overrides Materialize `float: left` default)
- Fixed Subscribe/Archives button icons separating from text (`display:
inline-flex`)
- Fixed mojibake ® encoding — 30 occurrences replaced with `®`
- Removed 243-line duplicate CSS block that was silently overriding all fixes
- Removed dead `nav .brand { display: none }` rule that was hiding sidebar
brand text
- Added WCAG Testing section to `CONTRIBUTING.md` (Lighthouse, WAVE, axe,
Oobee)
- Added cache-busting `?v=20260302h` on CSS links
## Why
130+ WCAG AA contrast failures made text unreadable across both themes. The
duplicate CSS block was the root cause of many fixes not taking effect.
## How tested
- Lighthouse: Desktop 100/100, Mobile 89/100
- WAVE WebAIM: 1.7 → 9.8
- Manually on 375px, 768px, 1440px in Chrome and Firefox, both light and
dark mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
