edk12564 opened a new pull request, #5574: URL: https://github.com/apache/fineract/pull/5574
JIRA: FINERACT-2518 ## Changes After investigating, it turns out PRs have been failing due to a mismatch between the CI/CD date locality (Asia/Kolkata), which is the default tenant timezone, and date locality used in SavingsAccountsExternalIdTests (UTC). At certain times of the day, we get a date mismatch, which corresponds to the errors we have been getting. The time of the CI/CD commit failures was around 1-2pm. Notably, this is 12am in Asia/Kolkata, resulting in a future date. Changed the hardcoded UTC to getLocalDateOfTenant() which is hardcoded to Asia/Kolkata. This matches the region CI/CD runs in. Failed CI/CD tests are similar between commits. We get failed data validation due to: ...cannot.be.before.client.activation.date. Below is a picture of the errors we get from CI/CD. <img width="1241" height="1112" alt="Screenshot 2026-03-02 at 6 53 46 PM" src="https://github.com/user-attachments/assets/1b386d57-d447-4717-a3a1-85bc833d900b"; /> ## Results Tests pass with changes: <img width="1651" height="460" alt="Screenshot 2026-03-02 at 7 11 49 PM" src="https://github.com/user-attachments/assets/ac30cd8f-c79f-44e4-a36e-428fed352997"; /> ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
