nidhiii128 commented on code in PR #5564:
URL: https://github.com/apache/fineract/pull/5564#discussion_r2876056047
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/SavingsAccountsExternalIdTest.java:
##########
@@ -59,7 +59,7 @@ void submitSavingsAccountsApplication() {
request.setProductId(1L);
request.setLocale(locale);
request.setDateFormat(dateFormat);
- request.submittedOnDate(formattedDate);
+ request.setSubmittedOnDate(formattedDate);
Review Comment:
Hi @meonkeys, I understand the concern. These changes weren't in my initial
commit, but were added because the integration tests failed during the CI
checks, when i made changes to these two files all checks passed and here where
you highlighted the submitedOnDate, I added the explicit setter
setSubmittedOnDate because the existing builder method wasn't correctly
populating the date field for the API request in this specific test case,
leading to 400 errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
