Wiki05 commented on code in PR #5592:
URL: https://github.com/apache/fineract/pull/5592#discussion_r2896951086
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/ProgressiveLoanScheduleGenerator.java:
##########
@@ -144,6 +144,10 @@ public LoanScheduleModel generate(final MathContext mc,
final LoanApplicationTer
scheduleParams.incrementPeriodNumber();
}
+ if (chargesDueAtTimeOfDisbursement.compareTo(BigDecimal.ZERO) > 0) {
+ scheduleParams.addTotalRepaymentExpected(Money.of(currency,
chargesDueAtTimeOfDisbursement, mc));
+ }
Review Comment:
Hi @Aman-Mittal , I've added a new unit test to
LoanScheduleGeneratorTest.java that verifies the inclusion of disbursement
charges in the total repayment. Please let me know if it looks good now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
